open-duelyst/duelyst

[P3] Repair and re-enable disabled SDK unit tests

Open

#25 创建于 2022年9月10日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)JavaScript (3,443 star) (526 fork)batch import
backendenhancementfrontendhelp wanted

描述

Several unit tests have been disabled until we have time to go back and update them. search for Test disabled in the repo to find them:

% git grep -l 'Test disabled'
test/unit/sdk/ai/ai.js
test/unit/sdk/ai/bosses.js
test/unit/sdk/cards/bloodstorm/faction6.js
test/unit/sdk/cards/bloodstorm/neutrals.js
test/unit/sdk/cards/core/faction2/artifacts.js
test/unit/sdk/cards/core/faction3/minions.js
test/unit/sdk/cards/core/faction5/spells.js
test/unit/sdk/cards/core/neutrals/epics.js
test/unit/sdk/cards/coreshatter/faction1.js
test/unit/sdk/cards/misc/bloodborn_spells.js
test/unit/sdk/cards/monthlies/month7.js
test/unit/sdk/cards/monthlies/month9.js
test/unit/sdk/cards/monthlies/seven_sisters.js
test/unit/sdk/cards/shimzar/battle_pets.js
test/unit/sdk/cards/shimzar/faction1.js
test/unit/sdk/cards/shimzar/faction2.js
test/unit/sdk/cards/shimzar/faction4.js
test/unit/sdk/cards/shimzar/faction5.js
test/unit/sdk/cards/unity/faction5.js
test/unit/sdk/cards/unity/faction6.js
test/unit/sdk/cards/wartech/faction2.js
test/unit/sdk/cards/wartech/faction3.js
test/unit/sdk/cards/wartech/faction4.js
test/unit/sdk/cards/wartech/faction5.js
test/unit/sdk/game/basic.js

We should revisit these and turn them back on once we get them working.

贡献者指南

技术栈
javascript
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
JavaScript programmingUnit testing experienceNode.js environment setup
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
First, use git grep to locate files containing 'Test disabled' as listed in the issue (e.g., test/unit/sdk/ai/ai.js). For each file, examine the disabled test(s) and understand the logic. Look for comments or recent changes that caused the test to fail. Update the test code to fix any issues and remove the 'Test disabled' marker. Ensure all tests pass. The repository uses JavaScript and likely a testing framework like Mocha or Jest—check package.json for details. No linked PRs or assignees exist, so this is open for taking.