onivim/oni

Syntax Highlighting: Use with `<c-/>` command

Open

#2,058 创建于 2018年4月6日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)TypeScript (11,389 star) (336 fork)batch import
enhancementhelp wantedinsider

描述

There is a somewhat undocumented command which is like an enhanced find-in-buffer experience, accessible via <c-/>:

super-search

It's a really cool feature! The only downside with it is that it doesn't respect syntax highlighting. I believe that with the work we have in the textmate highlighting feature, it should be possible to get syntax highlighting here.

We expose an API for querying the tokens / highlights as a syntaxHighlighter object off of he editors: https://github.com/onivim/oni/blob/a99544bdffbceb07c86a1f8c0da614ef7c2e4f52/browser/src/Editor/NeovimEditor/NeovimEditor.tsx#L175

And that has a method for getHighlightTokenAt: https://github.com/onivim/oni/blob/a99544bdffbceb07c86a1f8c0da614ef7c2e4f52/browser/src/Services/SyntaxHighlighting/SyntaxHighlighting.ts#L116

But, we also have the full set of tokens on the line - so it might be worth creating an API like getTokensForLine(bufferId, lineNumber) - if we had that, it should be pretty straightforward to get the token colors and show some nice syntax highlighting here 👍

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Knowledge of TypeScript and ReactUnderstanding of existing SyntaxHighlighting service
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Investigate the super search component triggered by <c />. Examine the existing `syntaxHighlighter` object and `getHighlightTokenAt` method in `browser/src/Services/SyntaxHighlighting/SyntaxHighlighting.ts`. Consider creating a new API `getTokensForLine(bufferId, lineNumber)` to retrieve all tokens for a given line. Then modify the super search view to use this API to color tokens, referencing the token colors from syntax highlighting. Review comments on the issue for any additional context or suggested approaches.