onivim/oni

Bug - Configuration: If there is only a `config.tsx` present, config doesn't load until saved once

Open

#2,056 创建于 2018年4月6日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)TypeScript (336 fork)batch import
bughelp wantedinsider

仓库指标

Star
 (11,389 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

It's common to save out the dotfiles of your config - like stashing a config.tsx somewhere, and sharing it between machines.

Repro:

  • Customize your configuration by saving a value in your config.tsx
  • Delete the config.js that is (generated) next to your config.tsx
  • Reload Oni

Expected: Configuration changes should still be present Actual: Configuration changes are not present

Oni actually uses a config.js, and when you save the config.tsx, it automatically generates the corresponding config.js. It doesn't make sense to check-in both of these, but if you only bring over a config.tsx, the config.js won't be generated until you've saved your config.tsx once.

We should detect this case (where there is a config.tsx, but no corresponding config.js) and attempt to transpile it on startup.

贡献者指南