onivim/oni

After config.tsx is changed. config.js is not re-generated

Open

#1,934 创建于 2018年3月26日

在 GitHub 查看
 (21 评论) (0 反应) (0 负责人)TypeScript (11,389 star) (336 fork)batch import
bughelp wanted

描述

After working for a while, changes to config.tsx no longer regenerates config.js. Tried restarting, stripping down config.tsx, touching config.js, etc. It started working again after I chose Preferences > Edit Oni config (which also help verify that I was editing the right copy of config.tsx.

Can't reproduce anymore.

v0.3.1

贡献者指南

技术栈
typescriptreact
领域
build system
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
unclear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
10
研究方向
The issue is about a watcher not regenerating config.js on config.tsx change, but it is not reproducible. Investigate the file watching or build system, possibly in the scripts or Electron main process that compiles TypeScript. Examine how the 'Edit Oni config' command triggers regeneration, as that seemed to fix the issue. Consider any race conditions or file system issues that might cause the watcher to miss changes.
After config.tsx is changed. config.js is not re-generated · onivim/oni#1934 | Good First Issue