onivim/oni

When tabs.mode == "buffers", moving/closing tabs is broken

Open

#1,768 创建于 2018年3月10日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (11,389 star) (336 fork)batch import
bughelp wanted

描述

I recently fixed the issue for tabs mode, but it seems like there is another bug affecting the tabs when in buffers mode.

How to reproduce:

  • Open a folder with 5-6 files
  • Open all the files as tabs
  • Attempt to select each one of them

What happens:

  • At some point it becomes impossible to select a tab
  • Even though tabs are not displayed as select, the Neovim editor still displays the content of the file clicked

Screen recording

贡献者指南

技术栈
typescript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
TypeScriptOni tab system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
Investigate the tab selection logic for `buffers` mode in Oni. Look for the previous fix for `tabs` mode (mentioned in the issue) and identify differences. Check the codebase for tab related components. Since no comments or PRs exist, start by reproducing the bug and examining the tab state management code.
When tabs.mode == "buffers", moving/closing tabs is broken · onivim/oni#1768 | Good First Issue