onivim/oni

Outline showing on Menu when clicking on it with mouse

Open

#1,750 创建于 2018年3月8日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)TypeScript (11,389 star) (336 fork)batch import
bughelp wanted

描述

I was playing around with the Menu (QuickOpen - Control+P / Command Palette - Control+Shift+P), and just noticed that when clicking inside the menu, we get a yellow outline border:

image

I believe this may be a result / regression from switching to react-virtualized. Might just need some styling tweaks on one of the containers here: https://github.com/onivim/oni/blob/bffb10f4c9808261259061bb0f9416a351b555c0/browser/src/Services/Menu/MenuComponent.tsx#L86

贡献者指南

技术栈
typescriptreact
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
ReactCSS
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Examine the MenuComponent.tsx file around line 86 (https://github.com/onivim/oni/blob/bffb10f4c9808261259061bb0f9416a351b555c0/browser/src/Services/Menu/MenuComponent.tsx#L86) to identify the container causing the yellow outline on click. The issue likely stems from a missing 'outline: none' CSS property on the focused element. Check if there is a global style or a library like react virtualized that sets an outline. The fix is to add CSS to remove the outline for menu items. Test by clicking the menu after the change.