olistic/warriorjs

Check if unit is alive after effects

Open

#63 创建于 2018年5月8日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)JavaScript (9,168 star) (528 fork)batch import
good first issuepkg: corestatus: claimedtype: enhancement

描述

A negative effect could potentially kill a unit. We need to check if the unit is still alive after executing the effects and return early if the unit died. Example: a "poisoned" effect (it doesn't exist, at least yet) that damages the unit turn by turn.

贡献者指南

技术栈
javascript
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with WarriorJS game logicUnderstanding of Unit.js effects execution
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
85
研究方向
Examine the Unit.js file in packages/warriorjs core/src, specifically the method that executes effects around line 98. Understand the current flow and add a check after calling the effects to verify the unit's health. If health is 0 or below, cause the unit to die or return early. This is a small localized change.