ocaml/dune

Adding some conditionals in the language

开放

#924 创建于 2018年6月28日

 (3 条评论) (0 个反应) (0 位负责人)OCaml (478 个派生)github user discovery
help wantedrule

仓库指标

星标
 (1,882 个星标)
PR 合并指标
 (平均合并 1天 20小时) (30 天内合并 345 个 PR)

描述

This is similar to #819 but with a somewhat broader scope. The idea would be to support (if <cond> <then> [else]) at the toplevel of a jbuild.

This would allow encoding the example of #819, which was:

(alias
 ((name runtest)
  (deps (foo.exe))
  (action (run ${<}))
  (enabled_if (and (<> ${os} win32) (>= ${ocaml_version} 4.0.5)))))

as

(if (and (<> ${os} win32) (>= ${ocaml_version} 4.0.5))
    (alias
     ((name runtest)
      (deps (foo.exe))
      (action (run ${<})))))

(of course I have nothing with the sugar proposed in #819).

But would also allow doing things like:

(if (= ${ocaml_version} "4.07._")
    (copy_files# 407/*.ml{,i}))
(if (= ${ocaml_version} "4.06._")
    (copy_files# 406/*.ml{,i}))
...

which are needed for merlin and currently require us to use ocaml jbuilds.


I'm only proposing to support this at the toplevel, but this could be pushed down to arbitrary places (after all, (select ...) already does similar things).

贡献者指南