ocaml/dune

Flush output buffers on SIGTERM

开放

#3,882 创建于 2020年10月21日

 (12 条评论) (0 个反应) (2 位负责人)OCaml (478 个派生)github user discovery
good first issue

仓库指标

星标
 (1,882 个星标)
PR 合并指标
 (平均合并 1天 20小时) (30 天内合并 345 个 PR)

描述

We're currently using dune runtest in OCaml-CI as the standard way of running tests for a package. If some of the tests for a package get stuck in a deadlock, the CI job will kill the process after 60 minutes. Unfortunately, this means that the logs of the stalled test run are lost.

We could switch to using dune runtest --no-buffer in the CI, but this creates less readable (interleaved) test output. One possible alternative would be for Dune to flush its output buffers before responding to SIGTERM (probably keeping the old behaviour for SIGKILL). What do you think?

贡献者指南