objectionary/eo-lsp-server

Redundant `config || defaultSettings` fallback in `validateTextDocument` at `server.ts`

开放

#338 创建于 2026年6月3日

 (5 条评论) (0 个反应) (0 位负责人)TypeScript (9 个派生)github user discovery
bughelp wanted

仓库指标

星标
 (6 个星标)
PR 合并指标
 (平均合并 4天 17小时) (30 天内合并 5 个 PR)

描述

In validateTextDocument, the settings are read with const effective = config || defaultSettings; followed by const limit = effective.limit; at src/server.ts:168. The config value is the resolved result of getDocumentSettings, which already guarantees a real settings object on every path: the no-configuration branch returns settings at src/server.ts:143, and the configuration branch falls back to defaultSettings inside its own .then at src/server.ts:150. By the time line 168 runs, config can never be null or undefined.

That makes the outer || defaultSettings a fallback that can never fire, and the effective variable just an alias for config. The two lines are equivalent to const limit = config.limit;.

The fix is to drop effective and read config.limit directly. The genuine default handling already lives inside getDocumentSettings, so it should stay there and not be removed.

贡献者指南