nytimes/library

Make the Recently/Most Viewed Stories dropdown optional based on Datastore config

开放

#28 创建于 2019年5月28日

 (0 条评论) (0 个反应) (0 位负责人)JavaScript (148 个派生)auto 404
enhancementgood first issue

仓库指标

星标
 (1,180 个星标)
PR 合并指标
 (PR 指标待抓取)

描述

Dropdown with Datastore Indexes set up:

Context (Environment)

A Library instance without Datastore Indexes set up.

Expected Behavior

Since setting up Datastore Indexes is optional, there should not be a dropdown if the indexes aren't set up.

Actual Behavior

Even without the indexes set up, an empty window still drops down. Screen Shot 2019-05-20 at 1 16 41 PM

Possible Solution

Enable/disable the dropdown depending whether the Datastore API/indexes are set up on the GCP project.

贡献者指南