nvbn/thefuck

EOL (end of line) issue on windows

Open

#1,189 创建于 2021年4月26日

在 GitHub 查看
 (1 评论) (2 反应) (0 负责人)Python (96,953 star) (3,949 fork)batch import
help wantedwindows

描述

The output of thefuck --version (something like The Fuck 3.1 using Python 3.5.0 and Bash 4.4.12(1)-release):

The Fuck 3.30 using Python 3.8.3 and ZSH 5.8

Your system (Debian 7, ArchLinux, Windows, etc.):

Windows 10 1909, cygwin and conemu

How to reproduce the bug:

In my environment, the commands generated by thefuck ends with "^M". It seems it's because all the output of thefuck ends with "\r\n" on windows. However, the zsh can only process commands end with "\n".

For example, when I run eval $(thefuck --alias), the error message is

zsh: parse error near `^M'

Any idea about this issue? Thank you.

贡献者指南

技术栈
pythonshell
领域
cli
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Python development environmentBasic knowledge of line endings
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue is that on Windows, thefuck outputs commands ending with \r\n, but ZSH expects \n only. Look at how thefuck prints its output, likely in files like `thefuck/shells/` or `thefuck/main.py`. Check where newlines are added and ensure only \n is used on Unix like shells. Consider using os.linesep or a conditional based on platform. The fix may involve modifying the output of the alias command or the corrected command itself.