nushell/nushell

Remove instances of `Span::unknown()` where possible

开放

#7,308 创建于 2022年12月1日

 (5 条评论) (1 个反应) (0 位负责人)Rust (2,129 个派生)batch import
A:error-handlingcategory:enhancementhelp wantedpolish

仓库指标

星标
 (39,478 个星标)
PR 合并指标
 (平均合并 4天 1小时) (30 天内合并 123 个 PR)

描述

Related problem

No response

Describe the solution you'd like

In a recent PR of mine, I was told not to use Span { start: 0, end: 0 } or Span::unknown() because when displayed in errors, they show garbage arrows pointing to arbitrary code.

However, these are still used in various places in the code, so I'm opening an issue for having them replaced with something else.

"Something else" because I don't have enough familiarity with the codebase to say what this would be. A better Span variant whose error arrows are explicitly not printed, perhaps?

Describe alternatives you've considered

No response

Additional context and details

No response

贡献者指南