nose-devs/nose2

Generator tests run on the wrong instance, causing setUp to be ineffective and other issues

Open

#533 创建于 2022年7月18日

在 GitHub 查看
 (1 评论) (1 反应) (0 负责人)Python (757 star) (137 fork)batch import
acceptedbughelp wanted

描述

This issue is a cleaned-up version of #80 , meant to capture the current context in nose2. It is an intentional duplicate to help make it easier to dive straight into this work, without getting tripped up on any of the older discussion.

There are several issues with respect to generator tests running on the wrong instance. Here's a clean reproduction:

$ cat test_gen.py
import unittest


class ExampleTest(unittest.TestCase):
    def setUp(self):
        print(f"setup on {id(self)}")

    def test_foo(self):
        def do_foo():
            print(f"run on {id(self)}")
        yield (do_foo,)
        yield (do_foo,)
        yield (do_foo,)

$ nose2 -v
test_foo:1
 (test_gen.ExampleTest) ... setup on 139890517293904
run on 139890517293328
ok
test_foo:2
 (test_gen.ExampleTest) ... setup on 139890517294720
run on 139890517293328
ok
test_foo:3
 (test_gen.ExampleTest) ... setup on 139890517294768
run on 139890517293328
ok

----------------------------------------------------------------------
Ran 3 tests in 0.001s

OK

The setup runs on different instances each time, which is supposed to happen. But then the test invocations happen on the same instance (and not one of the ones which got setup), which is not supposed to happen.


I'm going to try to make time to work on this after moving to python3-only, but I've also labelled it as 'help wanted'. If anyone wants to help try to understand and rework the generator test code, please feel free.

贡献者指南