nodejs/node

test_runner: do not read from `process.argv` and `process.cwd()` in run()

Open

#53,867 创建于 2024年7月16日

在 GitHub 查看
 (13 评论) (5 反应) (0 负责人)JavaScript (117,218 star) (35,535 fork)batch import
good first issuetest_runner

描述

Currently the codebase for https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/test_runner/runner.js#L472 accesses some poperties of process, capturing some options there. However, we also expose run() to the end users, therefore we should capture all this information in https://github.com/nodejs/node/blob/362afa52ebe462a39874915e5e70d261db153c58/lib/internal/main/test_runner.js#L68 and pass it down to run() as options.

贡献者指南

技术栈
javascriptnodejs
领域
backendtesting
议题类型
refactor
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
understanding of Node.js internalsknowledge of process.argv and process.cwd()familiarity with test runner module
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
The issue requires moving the capture of process.argv and process.cwd() from runner.js to test runner.js and passing them as options to run(). Examine the code in lib/internal/test runner/runner.js around line 472 and lib/internal/main/test runner.js around line 68 to understand current usage. Ensure that all dependencies on process properties are relocated and passed as parameters. No linked PRs or additional context in comments.