nodejs/node

Re-enable test-ubsan.yml

Open

#52,753 创建于 2024年4月29日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (117,218 star) (35,535 fork)batch import
help wantedmetastale

描述

During the latest Node.js major release (https://github.com/nodejs/node/pull/52505) we have had to disable test-ubsan.yml due to failing tests on a recent V8 update (https://github.com/nodejs/node/pull/52560).

I have tried to make it work, but due to the short time frame I had to fix it, we have decided to simply disable it for now.

Some insights:

  • It seems clang provides a better output and some docs we could use in the suppressions file.
    • Changing from g++ to clang for UBSAN will require changing all the suppression file

贡献者指南

技术栈
javascriptcpp
领域
ci cdtesting
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Node.js build systemUBSANC++ compiler basicsCI configuration
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine the disabled test ubsan.yml and the suppression files referenced in the insights. Investigate the V8 update that caused failures (PR #52560) and understand why g++ was used. Look into switching to clang for better output and updating the suppression file accordingly. Consult the linked PR #52505 for context.