nodejs/node

Cpplint produces false positives for FastApiOptions

Open

#45,761 创建于 2022年12月6日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)JavaScript (117,218 star) (35,535 fork)batch import
c++good first issuepython

描述

Following line is a perfectly fine declaration for v8 fast API.

using CFunctionCallbackWithInput =
    void (*)(v8::Local<v8::Value> receiver,
             const v8::FastOneByteString& source,
             const v8::FastApiTypedArray<uint8_t>& destination,
             const v8::FastApiTypedArray<uint32_t>& result,
             v8::FastApiCallbackOptions& options);

But it produces the following error

Running C++ linter...
src/node_encoding.cc:101:  Is this a non-const reference? If so, make const or use a pointer: FastApiCallbackOptions& options  [runtime/references] [2]
Done processing src/node_encoding.cc
src/node_external_reference.h:20:  Is this a non-const reference? If so, make const or use a pointer: v8::FastApiCallbackOptions& options  [runtime/references] [2]
Done processing src/node_external_reference.h
Total errors found: 2
make: *** [tools/.cpplintstamp] Error 1

贡献者指南

技术栈
cpp
领域
toolingdeveloper experience
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++ programmingcpplint knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
65
研究方向
Investigate the cpplint rule 'runtime/references' which flags non const references. The false positive occurs for FastApiCallbackOptions&, which is required by the V8 fast API. Check the cpplint configuration or add a suppression for this specific pattern. Look at the cpplint source (cpplint.py) to understand how to modify the rule or add an exception. Review comments in the issue for suggested fixes.