nodejs/node

Writable does not check if stream has been destroyed during _final and _write

Open

#39,030 创建于 2021年6月14日

在 GitHub 查看
 (21 评论) (1 反应) (0 负责人)JavaScript (117,218 star) (35,535 fork)batch import
good first issuesemver-majorstream

描述

Not sure if this is a problem but I think we should at least add a comment in the code that this case has been considered.

贡献者指南

技术栈
javascriptnodejs
领域
backenddocumentation
议题类型
documentation
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
active
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic knowledge of Node.js streams
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
Examine the source file `lib/ stream writable.js` in the Node.js repository, focusing on the ` write` and ` final` methods. Look for any existing checks for `destroyed` state and comments. The issue requests adding a comment to clarify the behavior when the stream is destroyed during these calls. Review the discussion in the issue comments for any specific concerns or suggested wording. Ensure the comment is added in the appropriate location within each method.