nodejs/node

Run tests with OPENSSL_CONF set to embedded openssl.cnf

Open

#24,373 创建于 2018年11月15日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)JavaScript (117,218 star) (35,535 fork)batch import
help wantedopenssltest

描述

  • Version: <= 10.13.0
  • Platform: Linux

when building with the --shared-openssl flag, it is highly probable that the openssl.cnf used by the shared library will be different than the one present in Node.js source code, resulting in several test failures. Typically, on debian, openssl is configured with stricter options regarding key length and TLS versions. It is very easy to avoid any test failure, though, by setting this environment variable when running tests: OPENSSL_CONF=./deps/openssl/openssl/apps/openssl.cnf

贡献者指南

技术栈
nodejsjavascript
领域
testingbackend
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Node.js test suiteBasic knowledge of OpenSSL configuration
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue suggests setting the OPENSSL CONF environment variable to the embedded openssl.cnf file when running tests with shared openssl. This can be implemented by modifying the test runner configuration, possibly in the Makefile or test scripts. Look at the test configuration files in the repository, such as 'Makefile' or 'test/common/' to add the environment variable.