nodejs/node

readline: processing \u2028 and \u2029

Open

#22,448 创建于 2018年8月21日

在 GitHub 查看
 (6 评论) (1 反应) (0 负责人)JavaScript (117,218 star) (35,535 fork)batch import
help wantedreadline

描述

Not sure if we should fix, document, or ignore this and if it has been discussed, so to be on the safe side.

Currently, \u2028 and \u2029 are considered as line breaks by JavaScript RegExps, while they are ignored by the readline:

'use strict';

const fs = require('fs');
const readline = require('readline');

const str = '123\n456\r123\u{2028}456\u{2029}789';

console.log(str.split(/^/mu));

fs.writeFileSync('readline-test.txt', str, 'utf8');

const rl = readline.createInterface({
  input: fs.createReadStream('readline-test.txt', 'utf8'),
  crlfDelay: Infinity,
});

rl.on('line', console.log);

out

Feel free to close if this is a wontfix.

贡献者指南

技术栈
javascriptnodejs
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Node.js readline moduleUnicode line separators
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the readline module's line splitting logic in lib/readline.js. The issue shows that \u2028 and \u2029 are not treated as line breaks, while JavaScript RegExp does. Check the internal lineBreak regex and add the Unicode line separator characters (U+2028 and U+2029) to it. Also verify with existing tests and possibly add new tests for this case.