node-fetch/node-fetch

abort and correct the error message when `body.formData()` fails

Open

#1,509 创建于 2022年2月19日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (8,563 star) (1,061 fork)batch import
bughelp wanted

描述

Reproduction

Steps to reproduce the behavior:

  1. res = new Response('foo=bar').formData()

Expected behavior

reject with TypeError: Failed to fetch and then also abort the response/request.

Additional context for fixer in body.js -> formdata() look at the content-type header, if it's null or not a multipart or a searchparam and then abort the request to not leave it hanging and reject with a type error

贡献者指南

技术栈
javascriptnodejs
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Node.js basicsFetch API knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
70
研究方向
The issue requires modifying the `formdata()` method in `body.js` to check the `content type` header and abort the response/request if the content type is not multipart/form data or application/x www form urlencoded. The method should reject with a TypeError. See the reproduction steps: `new Response('foo=bar').formData()`. No linked PRs or assignees, so implementation is open.
abort and correct the error message when `body.formData()` fails · node-fetch/node-fetch#1509 | Good First Issue