noble/bleno

Crash on bonding

Open

#345 创建于 2017年10月20日

在 GitHub 查看
 (1 评论) (3 反应) (0 负责人)JavaScript (2,083 star) (465 fork)batch import
help wanted

描述

Executed option "Bond" on Bleno device in nRF Connect. Following stacktrace appears

PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:60
  var output = new Buffer(input.length);
                               ^

TypeError: Cannot read property 'length' of undefined
    at swap (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:60:32)
    at e (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:37:9)
    at Object.c1 (PROJECT/node_modules/bleno/lib/hci-socket/crypto.js:22:9)
    at Smp.handlePairingRandom (PROJECT/node_modules/bleno/lib/hci-socket/smp.js:130:12)
    at Smp.onAclStreamData (PROJECT/node_modules/bleno/lib/hci-socket/smp.js:58:10)
    at emitTwo (events.js:92:20)
    at emit (events.js:172:7)
    at AclStream.push (PROJECT/node_modules/bleno/lib/hci-socket/acl-stream.js:26:10)
    at BlenoBindings.onAclDataPkt (PROJECT/node_modules/bleno/lib/hci-socket/bindings.js:201:21)
    at emitThree (events.js:97:13)

hcidump.log

bleno 0.4.2 (from git) Distribution: Debian (Kali Linux) bluez 5.47

Linux POLO-1158 4.13.0-kali1-amd64 #1 SMP Debian 4.13.4-2kali1 (2017-10-16) x86_64 GNU/Linux

贡献者指南

技术栈
javascriptnodejs
领域
backendapi
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
无
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The crash occurs in `bleno/lib/hci socket/crypto.js` at the `swap` function where `input` is undefined. This happens during BLE pairing when `c1` is called with undefined. Review the call chain: `Smp.handlePairingRandom` calls `c1` with possibly undefined values. The fix should add a null check on `input` in `swap` or ensure the caller provides valid data. Check the hcidump.log for context, but a simple guard clause should resolve.