ninja-build/ninja

CMake build doesn't enable the use of ppoll on platforms that support it

Open

#1,821 创建于 2020年7月28日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)C++ (10,194 star) (1,544 fork)batch import
help wanted

描述

On platforms that support it, configure.py enables the use of ppoll by defining USE_PPOLL. CMake build doesn't replicate this logic which means that Ninja built with CMake is always going to use the less efficient pselect.

贡献者指南

技术栈
cpp
领域
build system
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++CMakeplatform specific syscallsNinja build system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate how configure.py detects ppoll support via platform checks. Look at CMakeLists.txt to identify where to add a similar check. Use cmake's check symbol exists or check cxx source compiles to test for ppoll availability. Define USE PPOLL in the CMake build to match configure.py's logic.