nfl/react-helmet

Move typespec to this repo

Open

#358 创建于 2018年2月25日

在 GitHub 查看
 (1 评论) (3 反应) (0 负责人)JavaScript (17,167 star) (706 fork)batch import
enhancementgood first issuehelp wanted

描述

Is there any reason why we can't move the typespec from https://github.com/DefinitelyTyped/DefinitelyTyped to this repo so we do not have to deal with two packages.

We could copy that into this package and add "types": "./lib/main.d.ts" in the package.json

贡献者指南

技术栈
typescriptreact
领域
developer experience
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Familiarity with TypeScript type definitionsUnderstanding of npm package.json
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
First, find the existing type definitions in DefinitelyTyped for react helmet (https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react helmet). Copy the relevant .d.ts files into this repo, e.g., into a 'types' directory. Then, update package.json by adding a 'types' field pointing to the new declaration file (e.g., "./lib/main.d.ts"). Ensure the types align with the current API. Check the issue comments for any maintainer feedback.