nextcloud/server

Clear / refresh 2FA backup codes

Open

#9,036 创建于 2018年3月30日

在 GitHub 查看
 (9 评论) (0 反应) (0 负责人)PHP (34,953 star) (4,865 fork)batch import
1. to developenhancementfeature: authenticationgood first issuehelp wanted

描述

as already mentioned in https://github.com/nextcloud/twofactor_totp/issues/244, maybe just a question... but shouldn't the Backup-Codes be cleared/deleted after an user disables his 2FA?

in the database they are still present, also for users which were completely deleted ages ago.

i'm not sure if this may even become a security issue, especially if a user enables 2FA again...

贡献者指南

技术栈
无
领域
securityauthentication
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PHPNextcloud 2FA conceptDatabase migrations
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Look at the twofactor totp app (apps/twofactor totp/) and its database schema. Review issue #244 for prior discussion. Implement cleanup logic to delete backup codes when 2FA is disabled, and also remove codes for deleted users. Check the existing event hooks and migration files.