nextcloud/server

Plural missing on CalDAV Activity when creating multiple Calendar events

Open

#5,528 创建于 2017年6月24日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)PHP (34,953 star) (4,865 fork)batch import
1. to develop32-feedbackbugfeature: activity and notificationfeature: caldavfeature: language/translations (l10n/i18n)good first issuepapercut

描述

Steps to reproduce

  1. Create multiple events around the same time on Nextcloud Calendar
  2. Look at your Activities
  3. An activity stating "You created event Event 1, Event 2..."

Expected behaviour

If multiple events are created, activity should read as "You created events Event 1, Event 2..."

Actual behaviour

The word "event" is not plural.

Server configuration

Nextcloud 12

Operating system: N/A

Web server: N/A

Database: N/A

PHP version: N/A

Nextcloud version: 12

Updated from an older Nextcloud/ownCloud or fresh install: N/A

Where did you install Nextcloud from: git source

Client configuration

Browser: Noticed on Nextcloud-dev Android client, but client agnostic

Relevant code seems to be here: https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/Activity/Provider/Event.php#L89

贡献者指南

技术栈
php
领域
backend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
1
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic PHP knowledgeUnderstanding of Nextcloud activity system
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue is in the file `apps/dav/lib/CalDAV/Activity/Provider/Event.php` around line 89. The string 'event' needs to be pluralized to 'events' when multiple events are created. Look at the method that constructs the activity message; it likely receives a count or an array of events. Adjust the string to use a conditional plural form, e.g., using a ternary operator or a translation function that supports pluralization. Test by creating multiple events and checking the activity output.
Plural missing on CalDAV Activity when creating multiple Calendar events · nextcloud/server#5528 | Good First Issue