nextcloud/server

Enable usage of svg favicons and remove imagick from iconbuilder

Open

#36,607 创建于 2023年2月8日

在 GitHub 查看
 (11 评论) (4 反应) (0 负责人)PHP (34,953 star) (4,865 fork)batch import
1. to developfeature: theminghelp wantedtechnical debt

描述

This allows us to get rid of using imagick in iconbuilder of the theming app, which in return allows us to not enforce this requirement anymore since gd and imaginary can be used for all other tasks.

Julius found this: https://www.leereamsnyder.com/blog/favicons-in-2021#safari-does-not-fully-support-svg-icons

cc @juliushaertl

贡献者指南

技术栈
php
领域
backend
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PHPNextcloud server architectureTheming app concepts
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
The issue involves enabling SVG favicons in the iconbuilder of the theming app and removing the imagick dependency. The code is likely in the 'theming' app directory. Review the linked blog post about Safari SVG favicon support. Check comments for any ongoing work or additional requirements. Ensure that the replacement using gd and imaginary handles all icon types. No linked PRs exist, so implement the changes from scratch, testing with various browsers.
Enable usage of svg favicons and remove imagick from iconbuilder · nextcloud/server#36607 | Good First Issue