nextcloud/android

status dialog: not able to set only "icon" / only "clear at"

Open

#9,855 创建于 2022年2月17日

在 GitHub 查看
 (3 评论) (1 反应) (0 负责人)Java (3,752 star) (1,719 fork)batch import
approvedbugfeature: statusgood first issue

描述

Steps to reproduce

  1. set only icon or only clear at without to enter status message
  2. click set staus

Expected behaviour

  • icon or clear at are set

Actual behaviour

  • icon or clear at not set

Environment data

Nextcloud app version: 3.19.0

solution

api seems to set single modification for icon or "clear at" only if status message is not empty (must be at least whitespace)

see android talk commit https://github.com/nextcloud/talk-android/pull/1668/commits/a89c5952fa2747c8877c7882a6106311257722bf

贡献者指南

技术栈
javaandroid
领域
mobile
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Android development basicsJava
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue is about setting only icon or clear at without a status message in the Nextcloud Android app. The expected behavior is that setting just the icon or clear at should work, but the API currently requires a non empty status message (at least whitespace). A similar fix was applied in the Android Talk app: see commit a89c5952fa2747c8877c7882a6106311257722bf. The solution likely involves modifying the API call in the status dialog to handle cases where status message is empty. Look at the status dialog implementation in the Nextcloud Android repository for the relevant network request code.
status dialog: not able to set only "icon" / only "clear at" · nextcloud/android#9855 | Good First Issue