Avoid using escaped special characters in local storage paths to improve compatibility with other apps · nextcloud/android#5371

(7 评论) (0 反应) (0 负责人)Java (3,752 star) (1,719 fork)batch import

enhancementhelp wantedhotspot: device storage

描述

Is your feature request related to a problem? Please describe.

Newer NextCloud client allows selecting a storage path, but NextCloud creates another folder underneath that path.

Regardless of which one you select

/storage/emulated/0/Android/media/com.nextcloud.client
/data/user/0/Android/media/com.nextcloud.client
/storage/emulated/0/Android/data/com.nextcloud.client

NextCloud will create another few subdirectories in this structure

The problem is when the or has special characters.

In my case, I can't host on port 80, and I'm using a subpath to host.

user = "testuser" server = "example.com:8888/nextcloud/"

So the combined path that the NextCloud client uses to store this file is

/storage/emulated/0/Android/media/com.nextcloud.client/testuser@example.com%3A8888%2Fnextcloud/somefile.txt

This causes many issues with other apps that try to read this file. VLC for one can read an audio file once but never read it again. While I can file a bug with them, attaching an image with LINE for example, while LINE sees the image, attaching it will fail. I can list off apps which have problems with it, but long story short is, there's quite a few that I encounter here and there.

Describe the solution you'd like

Preferably keep the path simple, with no special escaped characters. If NextCloud is trying to have a unique path for any servers you connect to, perhaps just store that somewhere in the database that server A points to path A.

Or hash the user+server and use that instead.

Any path is good as long as it doesn't have URLencoded escape sequences.

Describe alternatives you've considered

I have considered submitting bugs individually to apps that don't work with this special path, but it seems like the path with port number and an escaped '/' causes enough apps to fail that it might be better to fix the client instead.

I've also tried searching on the help forums and other github issues and have not seen anything reported which is similar.

Additional context

(I can provide additional shots of apps not working, but I feel like that is moot.)

贡献者指南

技术栈: javaandroid
领域: mobile
议题类型: feature
难度: 3
预计时间: 1-2 days
活动状态: stale
清晰度: clear
前置要求: JavaAndroid storage APINextcloud app codebase
新手友好度: 70
研究方向: Examine the file path construction in the Nextcloud Android app, likely in the storage or sync module. Look for where the username and server URL are concatenated to form the local directory path. Consider alternative approaches such as hashing the user+server string or using a database mapping to avoid URL encoded characters. Check existing code for similar patterns and test on devices with special characters in server paths.