`within` changes the behavior of `modules: {as: }` · ndmitchell/hlint#1615

(3 评论) (0 反应) (0 负责人)Haskell (1,594 star) (208 fork)batch import

good first issue

描述

We want to gradually become consistent with our naming of Data.List.NonEmpty, so we create an hlint rule:

- modules:
    - name: [Data.List.NonEmpty] 
      as: NE

I run hlint on our codebase to get all the currently failing examples, and I create a within to ignore them:

- modules:
    - name: [Data.List.NonEmpty] 
      as: NE
      within: [ ... ]

But now it starts complaining about importing Data.List.NonEmpty at all. It seems like within is causing it to ignore the as: key.

技术栈: 无
领域: tooling
议题类型: bug
难度: 3
预计时间: half day
活动状态: active
清晰度: clear
前置要求: Understanding of hlint configurationBasic Haskell knowledge
新手友好度: 40
研究方向: Investigate the interaction between the `within` and `as` keys in hlint's module rule parsing. Look at the source code that handles configuration (likely in files like `src/Hint/Module.hs` or similar). The issue suggests that applying a `within` list causes the `as` key to be ignored, so the parsing logic that applies filters for `within` may override or skip the `as` mapping. Check how the module rules are transformed when `within` is present and ensure that the `as` alias is preserved.