ndmitchell/hlint

Incorrect redundant bracket warning with OverloadedRecordDot

Open

#1,458 创建于 2023年2月13日

在 GitHub 查看
 (2 评论) (0 反应) (0 负责人)Haskell (1,594 star) (208 fork)batch import
buggood first issue

描述

given

newtype T = T { f :: B }

g :: A -> T
a :: A

The code

(g a).f

uses the record dot operator. HLint recognizes this as the compose operator and incorrectly warns of a redundant bracket. Removing the bracket breaks the code, of course.

贡献者指南

技术栈
无
领域
tooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Haskell programmingfamiliarity with HLint internalsunderstanding of OverloadedRecordDot
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
Examine the HLint source code to find the rule that flags redundant brackets, likely in a file like 'Hint/Bracket.hs' or similar. Understand how the rule currently handles the composition operator (.) and check if it incorrectly triggers when the dot is used for record field access (OverloadedRecordDot). The issue's comments may provide additional context on the expected behavior. A fix would involve adjusting the pattern matching to distinguish between the composition operator and the record dot operator.
Incorrect redundant bracket warning with OverloadedRecordDot · ndmitchell/hlint#1458 | Good First Issue