ndelvalle/v-click-outside

The isActive config is ignored when updated dynamically

Open

#143 创建于 2019年11月8日

在 GitHub 查看
 (2 评论) (0 反应) (1 负责人)JavaScript (959 star) (90 fork)batch import
bughelp wanted

描述

I'm trying to disable the behavior of the click outside dynamically by changing the isActive property of the config object but the behavior still the same.

I know I can use the middleware to handle this (check line 36) but I don't know if the config of click outside expects to be dynamically.

https://codesandbox.io/s/v-click-outside-e4vin

贡献者指南

技术栈
javascriptvue
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Understanding of Vue reactivityFamiliarity with Vue directives
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
35
研究方向
The issue is that the `isActive` property in the config object is not being observed when changed dynamically. The fix likely involves adding a watcher or recomputing the directive's behavior when `isActive` changes. Check the source file `src/directive.js` for how the config is bound and if there's a mechanism to react to changes. The CodeSandbox linked in the issue (https://codesandbox.io/s/v click outside e4vin) demonstrates the problem. The assignee might have insights; review any existing comments or PRs for potential solutions.