mysqljs/mysql

It would be good to add some idleTimeout to pool options

Open

#962 创建于 2014年12月18日

在 GitHub 查看
 (9 评论) (5 反应) (0 负责人)JavaScript (18,137 star) (2,502 fork)batch import
featurehelp wanted

描述

Hello,

I am using this module for a long time but it lacks one failsafe element. My code for database functions became very big and it is hard to find where connection is not closed or if some errors happened before connection is closed that connection will stay idle and eventually when all are consumed from the pool the application hangs on database calls. It would be good to add some option like idelConnectionTimeout that will destroy a connection from a pool if it is idle for set time. This way pool will never stuck and will create fresh connections to replace those that hanged. Also if some mechanism could be made to auto close connection on end that would be great but i think that is not an option...

贡献者指南

技术栈
javascriptnodejssqlmysql
领域
backenddatabase
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic understanding of Node.jsfamiliarity with MySQL pool
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
50
研究方向
The issue requests an idle connection timeout option for the connection pool. To implement, look at the pool source code in lib/pool.js and lib/pool config.js. The feature would involve adding a new configuration option like 'idleConnectionTimeout' and a timer to destroy idle connections. Review existing PRs or comments for design ideas.
It would be good to add some idleTimeout to pool options · mysqljs/mysql#962 | Good First Issue