mysqljs/mysql

Connections in pool have an infinite lifetime

Open

#1,276 创建于 2015年11月12日

在 GitHub 查看
 (8 评论) (4 反应) (0 负责人)JavaScript (2,502 fork)batch import
help wanted

仓库指标

Star
 (18,137 star)
PR 合并指标
 (30 天内没有已合并 PR)

描述

I have a process running all the time and when it idles for a while the connections in the pool are in a sleeping state. Eventually MySQL purges those connections based on the wait_timeout setting in my.cnf. Once this happens and I try to use a connection it will fail because the module assumes the connection is still live and tries to use it only to get a timeout or connection exception.

I would propose adding an option when creating a pool connection_lifetime which will work in a following way. When getting a connection from the pool, if the connection_lifetime is not exceeded we simply return the connection, if however it is exceeded we kill the selected free connection and create a new one in it's place. That should solve the issue.

贡献者指南