mumble-voip/mumble

Iterate through positional audio program names only once

开放

#5,712 创建于 2022年6月1日

 (4 条评论) (2 个反应) (0 位负责人)C++ (1,062 个派生)batch import
clientfeature-requestgood first issue

仓库指标

星标
 (5,642 个星标)
PR 合并指标
 (平均合并 6天) (30 天内合并 7 个 PR)

描述

Context

Right now Mumble iterates through every program name of every PID for every positional audio plugin. This is quite wasted CPU time if either the PID count is high or plugin count is high, as the time complexity is in $\mathcal{O}(PIDNum \cdot pluginNum )$.

Example: https://github.com/mumble-voip/mumble/blob/dd5df45313a937359285327f556557159bab758e/plugins/gtav/gtav.cpp#L81

Description

A better solution would be if each plugin tells Mumble what program name it is looking for, so that only Mumble has to iterate over the PID-list once.

Mumble component

Client

OS-specific?

No

Additional information

This issue originated from https://github.com/mumble-voip/mumble/pull/5704#issuecomment-1141938952

贡献者指南