mumble-voip/mumble

Connection Dialog Should Display Ping Issues (timeouts, packetloss)

Open

#3,158 创建于 2017年7月9日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)C++ (5,642 star) (1,062 fork)batch import
clientfeature-requesthelp wantedui

描述

I had internet connection issues the last two days and noticed the server stats are only updated on successful pings. That means that if you had 1 successful 30ms ping with user count and then none for 10 minutes the displayed info is 10 minutes old and wrong (/does not indicate connection issues).

If we start with timeouts we do not display anything. Maybe some negative feedback would be useful then as well (use case: user has only 1 favourite server; does not see that we ping unsuccessfully, connect button is greyed out).

贡献者指南

技术栈
cpp
领域
desktop
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
C++Qt
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
The issue requests that the connection dialog display indicators for ping failures (timeouts, packet loss) and not just rely on successful pings. To implement this, one would need to modify the ping handling logic in the Mumble client, likely in the files related to the connection dialog (e.g., `src/mumble/Connection.cpp` or similar). The current behavior only updates stats on successful pings, so the fix involves detecting and displaying failed pings, possibly by showing a 'Connection Lost' or latency graph with missing data points.
Connection Dialog Should Display Ping Issues (timeouts, packetloss) · mumble-voip/mumble#3158 | Good First Issue