mumble-voip/mumble

Settings window should be non-modal, and the "Apply" button should apply settings immediately

Open

#2,734 创建于 2017年1月17日

在 GitHub 查看
 (5 评论) (0 反应) (0 负责人)C++ (5,642 star) (1,062 fork)batch import
feature-requesthelp wantedui

描述

Hi I am on the latest v1.3 snapshot (64bit) and it appears that the apply button does not work as it should.

Simple steps to reproduce:

  1. Open Preferences
  2. Go to User Interface and change the "layout"
  3. Press apply

The new layout will not be applied until restart. However pressing "OK" works as it should and applies the setting correctly.

贡献者指南

技术栈
cpp
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Qt frameworkMumble build systemC++ basics
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
The issue reports that the Apply button in the Preferences window does not apply layout changes immediately, unlike the OK button. Investigate the event handling for the Apply button in the settings dialog. Look at files like `src/mumble/Settings.cpp` or `src/mumble/Preferences.ui` to understand the current behavior. Compare with the OK button logic. Ensure that the Apply button triggers the same apply logic as OK without closing the dialog. Consider whether making the window non modal is necessary for expected behavior.
Settings window should be non-modal, and the "Apply" button should apply settings immediately · mumble-voip/mumble#2734 | Good First Issue