mumble-voip/mumble

Automatic Pings do not seem to respect connecting and error states

Open

#2,627 创建于 2016年11月7日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C++ (5,642 star) (1,062 fork)batch import
Hacktoberfestclientfeature-requestgood first issuepriority/P3 - Somewhat important

描述

As per https://github.com/mumble-voip/mumble/pull/2622#issuecomment-258711918

I had Mumble open in a VM, trying to connect to an IP that no longer hosted a server. I got the usual errors for a while. I don't remember what it was: unable to connect?

Then, after 5-6 of them, I began getting "unable to send TCP pings to the server". I guess we start pinging before we should?

ServerHandler::run() sets up the recurring ping timer and immediately starts it. It does so after setting up the socket and initiating the connect (qtsSock->connectToHostEncrypted(qsHostName, usPort)), but without any adequate handling of no-success cases. The timer is local to the run() function; it is never paused on connection issues. So yes, we do start pinging and continue to ping in inadequate cases, namely before a server connection has been established.

Not sure where the (old) reconnect code is though, where the server automatically reconnects.

贡献者指南

技术栈
cpp
领域
desktop
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
C++Qt frameworkTCP networking
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Investigate ServerHandler::run() in the Mumble source code, specifically the setup of the recurring ping timer. The issue mentions that the timer is started before the connection is fully established, leading to pings being sent incorrectly during connecting or error states. Look at the referenced pull request #2622 for additional context. Potential fix involves pausing or not starting the ping timer until the server connection is confirmed.