morelinq/MoreLINQ

Revise tests to avoid using `Eumerable.Range`

Open

#1,044 创建于 2023年11月16日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)C# (3,495 star) (406 fork)batch import
Component-Testsgood first issuehelp wanted

描述

Starting with .NET 8, Eumerable.Range returns an instance of a private RangeIterator that implements IList<T> (see also dotnet/runtime#88249). A lot of the unit tests potentially went with the assumption that Eumerable.Range returns a pure sequence. There are some operators in MoreLINQ that are optimised for sources that are collections and/or lists so tests using Eumerable.Range may be testing those optimised paths rather than the actual intended path iterating the source as an IEnumerable<>. Those tests need to be revised to avoid Enumerable.Range altogether.

Potential candidates that need revision:

贡献者指南

技术栈
csharp
领域
testing
议题类型
test
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
3-5 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
fresh
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Basic C#Unit testingLINQ knowledge
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
55
研究方向
Start by picking a few test files from the list (e.g., AggregateTest.cs, AppendTest.cs) in the MoreLinq.Test directory. Replace all uses of Enumerable.Range with a sequence that does not implement IList<T> (e.g., create a helper method that returns a custom IEnumerable<int> or use Enumerable.Range.AsEnumerable() to force non optimized path). Run the tests to ensure they still pass. Gradually apply to all listed files.