moment/luxon

Luxon not working on StackBlitz

Open

#552 创建于 2019年8月9日

在 GitHub 查看
 (1 评论) (2 反应) (0 负责人)JavaScript (14,588 star) (759 fork)batch import
help wantedissue: install/load

描述

With the introduction of the specific CDN rules (https://github.com/moment/luxon/pull/468), luxon no longer can be imported in StackBlitz. There is an issue for this over at StackBlitz (https://github.com/stackblitz/core/issues/986), but as far as I can see, this should be resolved here.

The problem is that the build/global file does not export anything, it just defines a variable called luxon that goes nowhere. This is not preferable, since the only way to import this, is by copying the file into another file (or using webpack, where it will magically work since you are copying everything in the same file, as specified by the original issue https://github.com/moment/luxon/issues/443.

Seems to me that the solution in #468 did not fix the problem, it only shifted it.

Proposal: Reverting #468 and reopening #443, figuring out what needs to be done exactly to resolve it.

贡献者指南

技术栈
javascript
领域
frontendtooling
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
JavaScript module systemsLuxon build setup
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
30
研究方向
Examine the changes in PR #468 and the original issue #443 to understand the UMD export problem. The issue arises because the build/global file does not export anything; it only defines a variable. A potential fix involves adjusting the build configuration to properly export the luxon object as a module, or reverting the CDN changes and finding an alternative solution. Check if there are any recent comments or commits addressing this, and propose a fix that ensures the library can be imported in StackBlitz without copying files.