mjackson/expect

Make `toNotThrow` say what was thrown

Open

#193 创建于 2017年2月3日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)JavaScript (2,290 star) (132 fork)batch import
enhancementhelp wanted

描述

expect(() => foo()).toNotThrow

fails when foo throws, but it doesn't tell me what error foo threw. This would be really useful for debugging. I'm happy to make a PR :)

PS: I'm also happy to try to help out more if you need help with this module :)

贡献者指南

技术栈
javascript
领域
testing
议题类型
feature
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptunderstanding of testing assertions
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue requests that the `toNotThrow` assertion method include the actual thrown error in the failure message. To implement this, locate the `toNotThrow` implementation in the repository (likely in `lib/expect.js` or similar). Modify the assertion to capture the thrown error and include it in the message. Refer to existing assertions like `toThrow` for how error messages are formatted. No linked PRs or assignees, so the issue is available for contribution.
Make `toNotThrow` say what was thrown · mjackson/expect#193 | Good First Issue