miraclx/freyr-js

High memory usage

Open

#646 创建于 2024年1月23日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (2,279 star) (154 fork)user submission
bughelp wanted

描述

Thank you for developing this app. I appreciate its user-friendliness.

However, I noticed that when downloading multiple large playlists and albums using queue, the app's memory usage spikes significantly. I wanted to point this out so that you can consider optimizing the memory management for these scenarios.

2024-01-23_16-29

Command used: npx freyr get https://open.spotify.com/artist/4CyxMgnF71FyOWADVWxJRE?si=ryq2taQMQtmXns5eyoJtoA https://open.spotify.com/artist/1v7B6ZWa7QRQS3knn3Jvf4 https://open.spotify.com/playlist/37i9dQZF1DWXgtgITTKvYl https://open.spotify.com/playlist/37i9dQZF1DX5wgKYQVRARv

贡献者指南

技术栈
javascriptnodejs
领域
cli
议题类型
performance
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
4
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-2 days
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
Node.js memory profilingCLI tool debugging
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
25
研究方向
Investigate memory usage spikes during concurrent downloads. Use Node.js heap snapshot tools (e.g., inspect) to identify objects retaining memory. Look at the download queue implementation in the source code (likely in src/ directory). Check for any unstreamed responses or caches growing unboundedly.
High memory usage · miraclx/freyr-js#646 | Good First Issue