mimblewimble/grin

Rust-yaml dependency must be updated

Open

#2,175 创建于 2018年12月18日

在 GitHub 查看
 (4 评论) (0 反应) (0 负责人)Rust (4,876 star) (991 fork)batch import
good first issuetask

描述

Currently we use 0.4.2 (used by serde) and 0.3.5 (used by clap). Cargo audit is unhappy:

$cargo audit
    Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
      Loaded 17 security advisories (from /home/ubuntu/.cargo/advisory-db)
    Scanning Cargo.lock for vulnerabilities (311 crate dependencies)
error: Vulnerable crates found!

ID:      RUSTSEC-2018-0006
Crate:   yaml-rust
Version: 0.3.5
Date:    2018-09-17
URL:     https://github.com/chyh1990/yaml-rust/pull/109
Title:   Uncontrolled recursion leads to abort in deserialization
Solution: upgrade to: >= 0.4.1

error: 1 vulnerability found!

I sent a PR against clap, opening this issue to track the update https://github.com/clap-rs/clap/pull/1396

贡献者指南

技术栈
rust
领域
security
议题类型
security
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
RustCargo
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
The issue tracks a security vulnerability in yaml rust dependency. A PR has been sent to clap to update its dependency (link: https://github.com/clap rs/clap/pull/1396). To resolve this issue, the maintainer needs to update the version of yaml rust in the Cargo.toml file, ensuring compatibility with serde's version. Check the linked PR for any required changes and test the build.