mike-north/ember-cli-materialize

[Bug] Parallax doesn't tear its self down completely

Open

#85 创建于 2015年4月24日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (305 star) (117 fork)batch import
bugfixed in materialize-v1.0.0help wantedv0

描述

The following Materialize code registers various listeners, which should be torn down in the component's willDestroyElement hook

this.$('.parallax').parallax();

Potentially this will entail adding some "cleanup" methods to the Materialize project, which can then be called by this component

贡献者指南

技术栈
javascriptcsshtml
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Understanding of Ember.js component lifecycleKnowledge of jQuery event handling
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
40
研究方向
First, locate the Ember component file that initializes the parallax (likely in addon/components). Check if there is already a willDestroyElement hook and what cleanup is missing. Then, look at the Materialize parallax plugin source (typically in vendor or bower components) to see if it provides a destroy method. If not, the fix may involve adding a custom cleanup function that removes event listeners and the parallax instance. Review the single comment on the issue for any additional context.