mike-north/ember-cli-materialize

[Bug] Navbar doesn't tear its self down completely

Open

#84 创建于 2015年4月24日

在 GitHub 查看
 (1 评论) (0 反应) (0 负责人)JavaScript (305 star) (117 fork)batch import
bugfixed in materialize-v1.0.0help wantedv0

描述

Calling the Materialize javascript

this.$('.button-collapse').sideNav({
  closeOnClick: true
});

Sets up some click listeners, which should be torn down in the component's willDestroyElement hook. Potentially this means enhancing the upstream Materialize project, or writing some ember-idiomatic code that does the same thing

贡献者指南

技术栈
javascriptcss
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
Ember.js component lifecycleMaterialize sideNav initialization
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Investigate the Ember component that initializes the sideNav. In the component's `willDestroyElement` hook, ensure that all click listeners set up by Materialize's sideNav are properly removed. This may require calling the destroy method of the sideNav instance or overriding Materialize's teardown. Review the Materialize source for a cleanup method.
[Bug] Navbar doesn't tear its self down completely · mike-north/ember-cli-materialize#84 | Good First Issue