miguel-perez/smoothState.js

Ajax success method issue

Open

#229 创建于 2015年11月5日

在 GitHub 查看
 (4 评论) (1 反应) (0 负责人)CSS (4,433 star) (515 fork)batch import
bughelp wanted

描述

Hello,

My implementation has been choking on line 375 letting me know that $.ajax(settings).success(...) is not a function. After researching it seems that the success / error / complete callbacks can be defined in the settings object but there is no such function, the closest being done().

So I changed the source code to settings.success = function(...) and the same for error and complete, before calling $.ajax(settings).

It seems to be working. But not being a developper I'm not really sure that would be the appropriate fix...

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
mostly clear
前置要求
basic jQueryJavaScript
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
Investigate the issue in the smoothState.js repository. The user reports that line 375 in the main JavaScript file uses $.ajax(settings).success(), which is deprecated since jQuery 1.8. The suggested fix is to use .done() instead. However, confirm that the library still supports older jQuery versions and check if any other deprecated methods are used elsewhere. Also, verify that the current maintainer is active and whether a PR would be welcome.