miguel-perez/smoothState.js

storePageIn() fails to find container in new doc if nested

Open

#193 创建于 2015年7月8日

在 GitHub 查看
 (8 评论) (0 反应) (0 负责人)CSS (4,433 star) (515 fork)batch import
bughelp wanted

描述

Nesting the container even one level under the body tag prevents storePageIn() from find it.

<body>
    <div>
        <article id="js-smoothstate-content">
            <h1>TEST CONTENT</h1>
        </article>
    </div>
</body>

The filter() function won't find the container id (Chrome v43):

storePageIn: function (object, url, doc, id) {
    /../
    object[url] = { // Content is indexed by the url
        /../
        html: $newDoc.filter('#' + id), // Stores the contents of the page
    }; 
}

Consider using .find() instead?

贡献者指南

技术栈
javascript
领域
frontend
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
2
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
under 1 hour
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
basic JavaScriptjQuery
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
80
研究方向
The issue reports that storePageIn() uses .filter() to find the container element, which fails when the container is nested inside another element. The suggested fix is to use .find() instead. Check the source code in smoothState.js around the storePageIn function (likely lines 100-150) and verify that changing $newDoc.filter('#' + id) to $newDoc.find('#' + id) resolves the issue without breaking other functionality. Also ensure that the id is correctly scoped and that no other parts of the code rely on the .filter() behavior.
storePageIn() fails to find container in new doc if nested · miguel-perez/smoothState.js#193 | Good First Issue