microsoft/retina

edge cases for MetricConfiguration CRD

Open

#74 创建于 2024年3月19日

在 GitHub 查看
 (5 评论) (0 反应) (1 负责人)Go (293 fork)auto 404
good first issuetype/fix

仓库指标

Star
 (3,161 star)
PR 合并指标
 (PR 指标待抓取)

描述

If enableAnnotations=false, then advanced metrics won't show up unless a MetricConfiguration CRD exists (metric modules are initialized via metricModule's Reconcile()). We should initialize with default context options instead.

Also, should we support MetricConfiguration CRD when enableAnnotations=true? Right now, we do not: https://github.com/microsoft/retina/blob/9248f0d140e5c93da77bdbdf5e43ea3b0029cfd4/controller/main.go#L254-L268

贡献者指南