microsoft/perfview

Freeze processing in EventPipeEventSource if uncaught exception is thrown in callback.

Open

#1,290 创建于 2020年10月15日

在 GitHub 查看
 (0 评论) (0 反应) (0 负责人)C# (3,819 star) (687 fork)batch import
bughelp wanted

描述

Environment

  • Microsoft.Diagnostics.Tracing.TraceEvent: 2.0.61
  • Microsoft.Diagnostics.NETCore.Client: 0.2.141901
  • EventPipe sender app and receiver app's TFM: net5.0-rc2

Steps to reproduce

  1. run app which produce EventSource event periodically
  2. start EventPipe session by DiagnosticClient
  3. create EventPipeEventSource from event stream
  4. set callback to DynamicEventParser.All
    • Exception will be thrown in callback
  5. start processing

full test code is uploaded to gist

Expected result

callback is invoked periodicaly, or at least terminate event processing when EventPipeEventSource.StopProcessing is called.

Actual result

callback was never invoked again, and EventPipeEventSource.Process never returned, even if EventPipeEventSource.StopProcessing was called.

贡献者指南

技术栈
csharp
领域
observabilityperformance
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
half day
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
needs investigation
前置要求
C#.NETEventPipe
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
20
研究方向
Investigate the EventPipeEventSource class in the Microsoft.Diagnostics.Tracing.TraceEvent library to understand how callbacks are invoked and how exceptions are handled. The issue shows that an uncaught exception in the callback causes the event loop to freeze. Look for try catch blocks around callback invocations and ensure exceptions are caught to avoid freezing. Also check the StopProcessing mechanism to ensure it can interrupt a frozen loop.