microsoft/nni

No error raise for wrong type of result

Open

#3,641 创建于 2021年5月14日

在 GitHub 查看
 (3 评论) (0 反应) (1 负责人)Python (13,504 star) (1,830 fork)batch import
help wanteduser raised

描述

Describe the issue:

When parsing value in torch.tensor with dtype=torch.float to nni.report_intermediate_result and nni.report_final_result, there is no Exception raised and no result recorded.

It is desired to raise a ValueError, or auto-convert to python float (raise a ValueError when cannot be converted).

Environment:

  • NNI version:
  • Training service (local|remote|pai|aml|etc):
  • Client OS:
  • Server OS (for remote mode only):
  • Python version:
  • PyTorch/TensorFlow version:
  • Is conda/virtualenv/venv used?:
  • Is running in Docker?:

Configuration:

  • Experiment config (remember to remove secrets!):
  • Search space:

Log message:

  • nnimanager.log:
  • dispatcher.log:
  • nnictl stdout and stderr:

How to reproduce it?:

贡献者指南

技术栈
pythonpytorch
领域
machine learning
议题类型
bug
难度面向新贡献者的预计实现难度，1 表示很小改动，5 表示专家级工作。
3
预计时间有经验贡献者完成调查、实现、测试并准备 pull request 的粗略时间范围。
1-3 hours
活动状态议题当前的可参与程度：新鲜、活跃、陈旧、阻塞或等待维护者输入。
stale
清晰度议题是否清楚说明期望改动、验收标准和下一步。
clear
前置要求
PythonPyTorchNNI API
新手友好度1-100 的估计分数，表示该议题对首次贡献者的友好程度。
60
研究方向
Examine the implementation of report intermediate result and report final result in the NNI source code (likely in nni/report.py or similar). Add a type check for the result parameter; if it is a torch.Tensor, attempt to convert to a Python float or raise ValueError. Follow existing error handling conventions in the codebase. No pull requests are linked; the issue has an assignee but no recent activity.
No error raise for wrong type of result · microsoft/nni#3641 | Good First Issue